Conversation
Member
Author
|
@neoformit does this work ok for you? |
Contributor
|
I only work on Ubuntu LTS releases, and I think the rest of Galaxy AU's are the same. Is that right @cat-bro ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From what I can tell, apt-key was deprecated and the new method has been supported since Debian 11 and Ubuntu 22.04. Since no older releases of either are still supported I don't think there's a reason the role needs to handle that old case. As written the tasks didn't work for me on Debian 13, since the key download only occurred on Jammy and Noble.
So this removes most of that and just configures using the new supported method, while keeping the bits that unconfigure the old method. Plus, make the user responsible for specifying which distro they want to install packages for if they're not on a supported release.