James c iss2029 access token expiry#291
Open
James-Cocker wants to merge 14 commits intomainfrom
Open
Conversation
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
eamansour
reviewed
Apr 30, 2026
|
|
||
| // Check if token is expired | ||
| const isExpired = useMemo(() => { | ||
| if (!token.expiryTime) return false; |
Member
There was a problem hiding this comment.
For security purposes, if a token doesn't have an expiry time, then shouldn't we treat it as expired and force the user to create a new token?
Contributor
Author
There was a problem hiding this comment.
I believe that this variable is just used for styling purposes so it shouldn't have any impact on security. I'm thinking if the migration somehow doesn't work, then the tokens probably don't need to all display as expired - but maybe they should as they wouldn't be usable if that were the case.
Member
There was a problem hiding this comment.
Yes, I agree that they should all be displayed. That at least gives users a chance to delete old tokens.
Signed-off-by: James Cocker <james.s.earth@gmail.com>
…ormat dates correctly Signed-off-by: James Cocker <james.s.earth@gmail.com>
… corrected post request Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
Signed-off-by: James Cocker <james.s.earth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Refer to galasa-dev/projectmanagement#2029.
This PR supports the upcoming expiry token changes in galasa-dev/galasa#570 for the issue above.
Screenshot(s) of changes
Changes