add UserActions for bulk UserUpdateNodesAttrs#190
Open
TeunHuijben wants to merge 2 commits intomainfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
+ Coverage 91.07% 91.12% +0.05%
==========================================
Files 59 60 +1
Lines 2923 2942 +19
==========================================
+ Hits 2662 2681 +19
Misses 261 261 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The group actions make heavy use of the
UserUpdateNodeAttractions. They loop over all nodes and apply the update user actions one-by-one, including the expensivetracks.refresh.This PR makes a "bulk" version of this UserAction, to make that process faster.
(I needed this for the v2-branch, but as the functions are near-idential to main, might just as well change it on main, and pull into v2 😅)