Add devcontainer, update test_requirements.txt#892
Open
arogozhnikov wants to merge 2 commits intofsspec:mainfrom
Open
Add devcontainer, update test_requirements.txt#892arogozhnikov wants to merge 2 commits intofsspec:mainfrom
arogozhnikov wants to merge 2 commits intofsspec:mainfrom
Conversation
Member
|
How is this executed? Is this docker? I would say that requiring docker is actually more onerous. Simpler would be a pytest fixture that masks any environment variables that were creating trouble for you. |
Contributor
Author
Contributor
Author
|
For local development, pycharm and vs code support devcontainers now and start/manage container for you. |
Contributor
Author
you need devcontainer.json first to make button work correctly. |
Member
|
So you still need docker, and also one of the particular IDEs that supports this mechanism. I am mildly against the idea. |
Contributor
Author
|
up to you of course. I'd spend 10 minutes setting this up rather ~3 hours figuring out why tests didn't work on mac or on linux, but worked in CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation: makes easier to contribute.
Currently to test things locally I need to delete aws config, and manually change requirements for tests, create virtual env and setup pre-commit
I can confirm that after spinning up the container, I can run
pytest s3fsand it works: