Remove default formula for active power and energy#55
Merged
cwasicki merged 1 commit intofrequenz-floss:v0.x.xfrom Mar 23, 2026
Merged
Remove default formula for active power and energy#55cwasicki merged 1 commit intofrequenz-floss:v0.x.xfrom
cwasicki merged 1 commit intofrequenz-floss:v0.x.xfrom
Conversation
cwasicki
requested review from
Julius-Wiegand-Frequenz,
shsms and
simonvoelcker
With support for formulas derived from the component graph via assets API, this should not be used anymore to not silently default to a wrong formula. Signed-off-by: cwasicki <[email protected]>
There was a problem hiding this comment.
Pull request overview
Removes the implicit fallback formulas for active power/energy metrics so that formulas are no longer silently defaulted (and potentially incorrect), aligning configuration behavior with formulas derived from the Assets API component graph.
Changes:
- Removed auto-generated default formulas for
AC_POWER_ACTIVEand active energy metrics fromComponentTypeConfig.__post_init__.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simonvoelcker
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With support for formulas derived from the component graph via assets API, this should not be used anymore to not silently default to a wrong formula.