Open
Conversation
Author
this happens and we used Mvndi@c1ef885 in production so it didnt spam console, there's maybe a better way to fix that warning so i didnt put it in this pr |
Owner
How much does it spam the console? In 2.X.X it should happen only when a player joins and immediately after leaves the server (#35), not every time the |
Author
|
yea it’s just on join/leave |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature being discussed on Discord: https://discord.com/channels/876458743934648340/1398342968477487134
we used this in production on our server for a month and had no issues