Skip to content

Conversation

@rmscotty
Copy link
Contributor

This commit upgrades the FUSE API to protocol 7.36, it doesn't implement any of protocol 7.36's new features,

@github-actions
Copy link

github-actions bot commented Aug 27, 2025

Thank you for taking the time to contribute to FreeBSD!
There is an issue that needs to be fixed:

  • Missing Signed-off-by lines (bb30ac4)

Please review CONTRIBUTING.md, then update and push your branch again.

@emaste
Copy link
Member

emaste commented Aug 28, 2025

CC @asomers

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this change doesn't have any real functionality at all, I don't think you need to add tests for it. But I do recommend initializing out->body.init.flags2 in MockFS::init in the test suite.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't use fuse_libabi_geq here because data isn't fully initialized yet. It can't be initialized until the server responds to FUSE_INIT. Instead, you should always fully initialize the structure. And you should set FUSE_INIT_EXT. Otherwise the server might be expecting a structure of the wrong size.

@rmscotty rmscotty force-pushed the fuse__36 branch 2 times, most recently from 7ce632e to 998af1e Compare December 10, 2025 00:04
This commit upgrades the FUSE API to protocol 7.36,
it doesn't implement any of protocol 7.36's new features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants