Delete the property setter on uninstall#532
Open
nliechti wants to merge 4 commits intofrappe:developfrom
Open
Conversation
Author
|
@maharshivpatel I know this app is not gonna be maintained for long. But the current uninstall behaviour of the print_designer breaks all updated Instances to v16 as it effectively overwrites the |
nliechti
commented
Mar 31, 2026
Author
|
@NagariaHussain Can you maybe look at this and give it a go if its ok? I think this will cost a lot of users a lot of time to find the problem after they uninstalled the Print Designer when upgrading to v16 as this app is not very maintained at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property setter that overrides the available print pdf_generator is set to a wrong value on v16.