feat(compute): Check machine availability API#6009
Draft
the-bokya wants to merge 3 commits intofrappe:developfrom
Draft
feat(compute): Check machine availability API#6009the-bokya wants to merge 3 commits intofrappe:developfrom
the-bokya wants to merge 3 commits intofrappe:developfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (45.45%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6009 +/- ##
===========================================
- Coverage 43.99% 43.97% -0.03%
===========================================
Files 775 774 -1
Lines 55999 55983 -16
===========================================
- Hits 24638 24617 -21
- Misses 31361 31366 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tanmoysrt
reviewed
Apr 1, 2026
Comment on lines
+1222
to
+1224
| client = FrappeComputeClient( | ||
| url=self.frappe_compute_base_url, api_key=self.frappe_compute_api_key, api_secret=api_secret | ||
| ) |
Member
There was a problem hiding this comment.
Maybe move this to a method get_frappe_compute_client(..)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
check_machine_availability()for Frappe Compute. Also adds an optionalinstance_idparameter to it specifically for Frappe Compute.