Remove unused mermaid flavoured flow code#63
Merged
Conversation
Matthbo
commented
Mar 2, 2026
Member
Author
There was a problem hiding this comment.
Notice how the whitespace on newlines have changed, this is to be more consistent with lines that don't start with whitespaces anyway.
Sadly it doesn't look nice in code but this wont matter much when its used in the browser.
Matthbo
commented
Mar 2, 2026
Member
Author
There was a problem hiding this comment.
Removed filter that wont be necessary with the new flow code
Matthbo
commented
Mar 2, 2026
Member
Author
There was a problem hiding this comment.
I wasn't sure if this is the right thing to do, saving the true text content won't be useful for generating the svg so I fixed it this way.
Matthbo
commented
Mar 2, 2026
Member
Author
There was a problem hiding this comment.
Uses the flow code generated SVG text elements and adds the positioning attributes instead of generating new elements
mhdirkse
reviewed
Mar 3, 2026
mhdirkse
reviewed
Mar 3, 2026
mhdirkse
requested changes
Mar 3, 2026
mhdirkse
reviewed
Mar 3, 2026
mhdirkse
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.