Set ignore-branches-with-open-prs to ignore base of a PR as well#65
Open
trent-abc wants to merge 2 commits intofpicalausa:masterfrom
Open
Set ignore-branches-with-open-prs to ignore base of a PR as well#65trent-abc wants to merge 2 commits intofpicalausa:masterfrom
trent-abc wants to merge 2 commits intofpicalausa:masterfrom
Conversation
Author
|
I would also be open to a fix implemented by the authors which allows us to specify both, but in any case, this is the solution I have. |
fpicalausa
reviewed
Feb 20, 2026
| : undefined | ||
| this[kFactory] = factory | ||
|
|
||
| this.on('connectionError', (origin, targets, error) => { |
Owner
There was a problem hiding this comment.
Was this built with the existing dependencies? (odd this is being added)
Author
There was a problem hiding this comment.
No idea, we decided to not use this action so feel free to take this PR to completion, make your own implementation, or ignore it altogether and close the PR. For what it's worth, the PR content was just generated by the LLM. Testing it seems to have worked on my end but again I don't have skin in the game anymore on this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignore-branches-with-open-prs currently only ignores HEAD of a PR. This is unintuitive as there can also be base of a PR branches open.
This PR makes ignore-branches-with-open-prs ignore both HEAD and BASE of a PR branches (No PRs lost due to stale branches).