feat: implement unified notification system with toast alerts for user feedback#432
Open
AliRana30 wants to merge 2 commits intofossasia:mainfrom
Open
feat: implement unified notification system with toast alerts for user feedback#432AliRana30 wants to merge 2 commits intofossasia:mainfrom
AliRana30 wants to merge 2 commits intofossasia:mainfrom
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Sorry @AliRana30, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
github-actions
bot
added
javascript
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a unified toast-based notification system across the extension UI (popup/side panel), replacing legacy Materialize toasts and inline alert/error injections while also hardening a few related UX and query/date-handling paths.
Changes:
- Added a new
NotificationSystemutility for consistent, DOM-safe toast notifications. - Replaced several inline error message injections / Materialize toasts with unified toasts in popup + scrum generation flows.
- Normalized some date handling to local
YYYY-MM-DDformatting and improved org-filter query encoding/fallback behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/scripts/scrumHelper.js |
Uses unified toasts for popup feedback; improves date formatting and GitHub org query handling. |
src/scripts/popup.js |
Replaces popup messaging with NotificationSystem, adds more user feedback and safer “insert into email” gating. |
src/scripts/notifications.js |
Introduces the new toast notification utility (DOM-built, XSS-safe). |
src/popup.html |
Loads the new notifications script and adjusts mode/layout-related markup/styles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@vedansh-5 PR is ready to be reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Refactors the notification system into a single unified approach.
Summary of Changes
Screenshots
Tested and verified modern toast animations in the UI.
Error toast :
Checklist
Fixes : #405