Open
Conversation
Author
|
Note: I use 'y' type for type conversion in C-Api so it can't be compiled with Python 2.7 |
Scondo
commented
Dec 8, 2021
|
|
||
| kwargs['gzip_mode'] = 0 | ||
| return zopfli.zopfli.compress(data, **kwargs) | ||
| return zopfli.zopfli.compress(bytes(data), **kwargs) |
Author
There was a problem hiding this comment.
Change this for some unittest.
Maybe change to 'y' in C code will be better solution, but this depends on compatibility with 2.7
Hope this help to understand code
+1 passed test
It was easier than I thought... *Don't know if it really improves compression efficiency, may be more tests required.
…'s not part of API. ZopfliCompress does not provide enough options to do partial compression. So we should use zopfli source. Almost sure it will be not compatible with system zopfli, so disable at least for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote this few years ago and almost forgot about it.
I hope you'll find it useful.
I add unittest from Python 3.10 to check if emulation is ok. It fails, but mostly on dictionary feature and difference between single and iterative compression.