Fix IAM credentials not setting universe domain properly#656
Merged
Conversation
Pass universe_domain as an option to Google::Auth.get_application_default instead of setting it on the credentials object after creation. This avoids errors in the Ruby SDK: `Universe domain is universe.example.com but credentials are in googleapis.com`.
stanhu
force-pushed
the
sh-fix-iam-universe-domain
branch
from
f959c5f to
9e60fb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass universe_domain as an option to
Google::Auth.get_application_defaultinstead of setting it on the credentials object after creation. This avoids errors in the Ruby SDK:Universe domain is universe.example.com but credentials are in googleapis.com.