Open
Conversation
The graceful shutdown sequence was missing wg.Wait() for worker goroutines, and had no overall deadline. This caused the process to hang indefinitely when workers (e.g. controller-runtime manager) were slow to stop, requiring repeated Ctrl+C. - Wait for all workers to finish with a 30s timeout - Support force exit on second SIGINT/SIGTERM - Make HTTP server shutdown errors non-fatal so worker cleanup still runs Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: Kevin Su <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wg.Wait()with a 30-second timeout for worker goroutinesTest plan
main