jobs table: store duration_delta#744
Open
cmoussa1 wants to merge 3 commits intoflux-framework:masterfrom
Open
Conversation
cmoussa1
added
improvement
Problem: The "jobs" table does not store the duration delta (i.e. the difference between a job's requested duration and its actual duration) anywhere in the database. Add the duration delta as a new column to the "jobs" table. Increment the database schema version number as a result of adding a new column.
Problem: The script that fetches recently completed jobs for accounting purposes does not INSERT the duration delta into the "jobs" table. Compute the duration delta and add it to the list of values INSERT-ed into the "jobs" table for each completed job.
Problem: The flux-accounting database from before the addition of the new duration_delta column to the "jobs" table is not in the testsuite, but it should be a part of the update-db tests since the schema has changed. Add a flux-accounting DB with schema version 31 to the testsuite.
cmoussa1
force-pushed
the
add.duration_delta.to.db
branch
from
a1626c7 to
decf3d0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
=======================================
Coverage 83.56% 83.56%
=======================================
Files 27 27
Lines 2421 2421
=======================================
Hits 2023 2023
Misses 398 398 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
jobstable does not store the duration delta (i.e. the difference between a job's requested duration and its actual duration) anywhere in the database.This PR adds the duration delta as a new column to the
jobstable, where it is also added to the list of valuesINSERT-ed for each completed job it sees.