feat: Update Dart BNF grammar and Grammar-Kit plugin#180
Open
jwren wants to merge 1 commit intoflutter:mainfrom
Open
feat: Update Dart BNF grammar and Grammar-Kit plugin#180jwren wants to merge 1 commit intoflutter:mainfrom
jwren wants to merge 1 commit intoflutter:mainfrom
Conversation
- Update `org.jetbrains.grammarkit` to `2023.3.0.1`. - Regenerate parser and lexer files with the new plugin version. - Note: The new version introduces `recursion_guard_` and renames variables (e.g., `b` -> `builder_`) in the generated parser. - Configure `generateDartParser` task to include compiled classes (via `sourceSets["main"].output`) to correctly resolve `DartPsiImplUtil` methods during generation. - Add `verify-parser` job to `presubmit.yaml` to ensure generated files are up-to-date. - Runs `./gradlew classes` before generation to ensure dependencies are built. - Remove `_DartDocLexer` as it is now handled by the main lexer generation.
Collaborator
|
I'd love to walk through this... Wanna fix the merge conflict so it's ready to go? |
Member
Author
|
Yes, I'll try to do this soon, and we can walk through it together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.jetbrains.grammarkitto2023.3.0.1.recursion_guard_and renames variables (e.g.,b->builder_) in the generated parser.generateDartParsertask to include instrumented classes and compile classpath to correctly resolveDartPsiImplUtilmethods during generation.verify-parserjob topresubmit.yamlto ensure generated files are up-to-date.