Merge pull request #950 from flippercloud/expression-sync

Expression sync

Author: jnunemaker

lib/flipper/adapters/sync/feature_synchronizer.rb

@@ -53,9 +53,13 @@ def call
         private
 
         def sync_expression
-          return if remote_expression.nil? || local_expression == remote_expression
+          return if local_expression == remote_expression
 
-          @feature.enable_expression remote_expression
+          if remote_expression.nil?
+            @feature.disable_expression
+          else
+            @feature.enable_expression remote_expression
+          end
         end
 
         def sync_actors

spec/flipper/adapters/sync/feature_synchronizer_spec.rb

@@ -105,9 +105,10 @@
       expect_no_enable_or_disable
     end
 
-    it "updates expression when remote is updated to nil" do
-      remote = Flipper::GateValues.new(expression: nil)
+    it "updates expression when remote conditionally enabled but expression is nil" do
+      remote = Flipper::GateValues.new(expression: nil, actors: Set["1"])
       feature.enable_expression(plan_expression)
+      feature.enable_actor(Flipper::Actor.new("1"))
       adapter.reset
 
       described_class.new(feature, feature.gate_values, remote).call