Merge pull request #949 from jdnvn/main

fix sync behavior when remote expression value is set to nil

Author: jnunemaker

lib/flipper/adapters/sync/feature_synchronizer.rb

@@ -53,7 +53,7 @@ def call
         private
 
         def sync_expression
-          return if local_expression == remote_expression
+          return if remote_expression.nil? || local_expression == remote_expression
 
           @feature.enable_expression remote_expression
         end

spec/flipper/adapters/sync/feature_synchronizer_spec.rb

@@ -105,6 +105,17 @@
       expect_no_enable_or_disable
     end
 
+    it "updates expression when remote is updated to nil" do
+      remote = Flipper::GateValues.new(expression: nil)
+      feature.enable_expression(plan_expression)
+      adapter.reset
+
+      described_class.new(feature, feature.gate_values, remote).call
+
+      expect(feature.expression_value).to eq(nil)
+      expect_only_disable
+    end
+
     it "adds remotely added actors" do
       remote = Flipper::GateValues.new(actors: Set["1", "2"])
       feature.enable_actor(Flipper::Actor.new("1"))