Show base branch in PR title#332
Conversation
|
I wonder if it could be more generic - instead of a boolean option determining whether or not to put branch name into PR title, use a string option with PR title template, with |
|
Is this still needed? Instead of having branch in the title, labels would be better I think. fedc as of yesterday supports setting PR labels. Also the base branch is included in the branches it creates |
|
I'm already using labels. The problem with labels is that they don't show up in Notifications. |
|
Ok so can you rebase and fix the conflict? IMO these minor things don't need be an argument and can be added by default to the title but if you prefer then it's ok. |
So just add it to the title when the branch is not master? |
|
You can add it even when it is master. There is no reason to special case a single branch. |
If it is different than the origin repo's default branch
The order of the arguments changed in PyGitHub's current version so newer documentation is confusing to look at. This was the order used in version closest to docker image (1.55) https://pygithub.readthedocs.io/en/v1.58.0/github_objects/Repository.html?highlight=create_pull#github.Repository.Repository.create_pull
bbhtt
changed the title
4 participants
f-e-d-c is currently used by com.riverbankcomputing.PyQt.BaseApp on 3 different branches. Having the branch (e.g. 5.15-22.08 or 6.3) would make it possible to see which branch is targeted directly in the Notification or the PR list.
Note: This is currently not tested