Make network markers in the network panel sticky on click#5884
Make network markers in the network panel sticky on click#5884fatadel wants to merge 1 commit intofirefox-devtools:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5884 +/- ##
==========================================
+ Coverage 85.41% 85.42% +0.01%
==========================================
Files 321 321
Lines 32037 32058 +21
Branches 8728 8823 +95
==========================================
+ Hits 27365 27387 +22
+ Misses 4241 4240 -1
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When clicking a marker in the Network panel, its tooltip is now persisted, matching the Marker Chart behavior. This enables interaction with tooltip content like copying text or clicking the filter button. The existing behavior of displaying the tooltip on hover is kept as well. Because of that, it should now be easier to compare two markers. - Add click coordinate tracking to NetworkChartRow state for sticky tooltip positioning - Show filter button only in sticky (clicked) tooltips - Toggle selection off when re-clicking the same row - Dismiss sticky tooltip on Escape key - Add 7 new tests covering the sticky tooltip related behavior
fatadel
force-pushed
the
sticky-markers-5751
branch
from
f9b12db to
1cc967a
Compare
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
Thanks!
It looks like when the network marker is sticky, we still see another tooltip on top of it, which obstructs the other one. Is it possible to make the other tooltips not visible when there is already a sticky tooltip?
See an example:
I see that we already do this in the marker chart/table. So it might be good to have the same behavior
Show filter button only in sticky (clicked) tooltips
I'm a bit confused by this one. Can we make it visible all the time? This is the current behavior of marker chart too.
2 participants
Closes #5751.
When clicking a marker in the Network panel, its tooltip is now persisted, matching the Marker Chart behavior. This enables interaction with tooltip content like copying text or clicking the filter button. The existing behavior of displaying the tooltip on hover is kept as well. Because of that, it should now be easier to compare two markers.
Before / After