Add startLine, startColumn, sourceMapURL and rename uuid to id in source table #5882
Conversation
81eb713 to
bba65ec
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5882 +/- ##
==========================================
- Coverage 85.42% 85.41% -0.02%
==========================================
Files 321 321
Lines 32073 32140 +67
Branches 8821 8757 -64
==========================================
+ Hits 27398 27451 +53
- Misses 4244 4257 +13
- Partials 431 432 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Nit: when writing in camelCase, I would prefer having |
That's valid, but I wanted to keep |
bba65ec to
bdcbeb6
Compare
fatadel
left a comment
There was a problem hiding this comment.
I've left some "nit" comments, but otherwise looks great. Thanks for the PR!
This will help us see the accurate line numbers in the source view for the inline JS scripts. And also, it will help us resolve the source maps later.
This will allow us to resolve the source maps later.
The name of this field doesn't make sense anymore as we changed its value from UUID to a hash value. This `id` name is more implementation agnostic, so it's better to rename it now. Note that this requires an upgrader, similar to the previous patches in this patch stack. The upgrader will happen in the last commit with all the relevant changes.
bdcbeb6 to
eeb4252
Compare
eeb4252 to
18721fd
Compare
The backend side of this PR:
This PR improves the source table overall by:
uuidfield toid. This field was initially containing uuid fields, but they were replaced to contain hashes instead. It's better to have an implementation agnostic name for this field in general.It's a bit difficult to test as it request profiling with the backend patches though. That's why it might be difficult to get a profile for deploy preview.
Also there isn't a UI visible change in this PR yet. The following PRs will use startLine/startColumn, and then sourceMapURL will be used for source map fetching.