Skip to content

Update home page message for the other browser case #5866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fatadel merged 3 commits into from
Mar 3, 2026
+8 −10
Merged

Update home page message for the other browser case #5866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12d73be
Update home page message for the other browser case
fatadel Feb 27, 2026
827cdef
Update translation key
fatadel Feb 27, 2026
4943d1c
Merge branch 'main' into refine-home-msg-5812
fatadel Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions locales/en-US/app.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,8 +377,8 @@ Home--record-instructions =
keyboard shortcuts. The icon is blue when a profile is recording.
Hit <kbd>Capture</kbd> to load the data into profiler.firefox.com.

Home--instructions-content =
Recording performance profiles requires <a>{ -firefox-brand-name }</a>.
Home--instructions-content2 =
Recording performance profiles requires <a>{ -firefox-brand-name } for desktop</a>.
However, existing profiles can be viewed in any modern browser.

Home--fenix-instructions-directly =
Expand Down
10 changes: 4 additions & 6 deletions src/components/app/Home.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,6 @@ type PopupInstallPhase =
class HomeImpl extends React.PureComponent<HomeProps, HomeState> {
constructor(props: HomeProps) {
super(props);
// Start by suggesting that we install the add-on.
let popupInstallPhase = 'other-browser';

if (_isFirefox()) {
Expand Down Expand Up @@ -570,16 +569,15 @@ class HomeImpl extends React.PureComponent<HomeProps, HomeState> {
<div>
<DocsButton />
<Localized
id="Home--instructions-content"
id="Home--instructions-content2"
elems={{
a: <a href="https://www.mozilla.org/en-US/firefox/new/" />,
a: <a href="https://www.firefox.com" />,
}}
>
<p>
Recording performance profiles requires{' '}
<a href="https://www.mozilla.org/en-US/firefox/new/">Firefox</a>
. However, existing profiles can be viewed in any modern
browser.
<a>Firefox for desktop</a>. However, existing profiles can be
viewed in any modern browser.
</p>
</Localized>
<Localized
Expand Down
4 changes: 2 additions & 2 deletions src/test/components/__snapshots__/Home.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,9 +975,9 @@ exports[`app/Home renders the information screen for other browsers 1`] = `
<p>
Recording performance profiles requires
<a
href="https://www.mozilla.org/en-US/firefox/new/"
href="https://www.firefox.com"
>
⁨Firefox⁩
⁨Firefox⁩ for desktop
</a>
.
However, existing profiles can be viewed in any modern browser.
Expand Down