Fix Python <3.12 compatibility in DiskCheckpointer#5010
Merged
connorjward merged 1 commit intofiredrakeproject:mainfrom Apr 9, 2026
Merged
Fix Python <3.12 compatibility in DiskCheckpointer#5010connorjward merged 1 commit intofiredrakeproject:mainfrom
connorjward merged 1 commit intofiredrakeproject:mainfrom
Conversation
firedrakeproject#4891 introduced the use of tempfile.TemporaryDirectory with the `delete` parameter. This was introduced in Python 3.12, and therefore this commit breaks compatibility with Python 3.10 and 3.11. pyproject.toml states that Python >= 3.10 is supported. Due to OS constraints, we'll be stuck on Python 3.11 on our HPC systems for some time.
connorjward
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#4891 introduced the use of
tempfile.TemporaryDirectoryinDiskCheckpointerwhich is created with thedeleteparameter. This parameter was introduced in Python 3.12, and therefore this commit breaks compatibility with Python 3.10 and 3.11.pyproject.tomlstates that Python >= 3.10 is supported. Due to OS constraints, we'll be stuck on Python 3.11 on our HPC systems for some time.This PR replaces
delete=Truewith a destructor for theDiskCheckpointerclass that calls theTemporaryDirectory's built-incleanup()method on deletion of theDiskCheckpointerobject.