Merged
Conversation
pbrubeck
force-pushed
the
pbrubeck/finat-boundary-quadrature
branch
4 times, most recently
from
6fde7d5 to
23e0397
Compare
pbrubeck
force-pushed
the
pbrubeck/finat-boundary-quadrature
branch
from
23e0397 to
7f2dd72
Compare
pbrubeck
force-pushed
the
pbrubeck/finat-boundary-quadrature
branch
from
19ff7ef to
e77ed6f
Compare
…ct/fiat into pbrubeck/simplify-indexed
pbrubeck
added a commit
that referenced
this pull request
Feb 21, 2025
Co-authored-by: Rob Kirby <[email protected]>
dham
requested changes
Mar 19, 2025
pbrubeck
commented
Mar 27, 2025
pbrubeck
commented
Mar 27, 2025
pbrubeck
commented
Mar 27, 2025
indiamai
reviewed
Mar 27, 2025
indiamai
left a comment
indiamai
left a comment
There was a problem hiding this comment.
A lot of this is to do with refactoring reduce to be handled in the new constructor. Has that been discussed/ it should be noted in the PR description.
pbrubeck
commented
Mar 27, 2025
Co-authored-by: India Marsden <[email protected]>
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sum/Producttake more than 2 arguments, and add support forDelta(tuple, tuple)Sum / Productremain as binary opertations, undre the hood they just callreduceon the arguments.