[AI] Conform GenerationConfig and Schema to Equatable#15949
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
There was a problem hiding this comment.
Code Review
This pull request adds Equatable conformance to GenerationConfig and Schema. The changes are straightforward and well-tested. For GenerationConfig, adding Equatable conformance is sufficient as the compiler can synthesize the implementation. For Schema, a manual implementation of Equatable is provided. I've suggested letting the compiler synthesize this as well for better maintainability. The new unit tests for Schema's Equatable conformance are comprehensive and cover various scenarios.
Added
Equatableconformance toGenerationConfigandSchemaas a prerequisite for makingTranscriptconform toEquatablein #15942. Added unit tests for theEquatableimplementation forSchemasince auto-synthesis is not supported for classes.#no-changelog