Skip to content

[AI] Conform GenerationConfig and Schema to Equatable#15949

Merged
andrewheard merged 1 commit intomainfrom
ah/ai-equatable-gen-config
Mar 19, 2026
Merged

[AI] Conform GenerationConfig and Schema to Equatable#15949
andrewheard merged 1 commit intomainfrom
ah/ai-equatable-gen-config

Conversation

@andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Mar 18, 2026

Added Equatable conformance to GenerationConfig and Schema as a prerequisite for making Transcript conform to Equatable in #15942. Added unit tests for the Equatable implementation for Schema since auto-synthesis is not supported for classes.

#no-changelog

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds Equatable conformance to GenerationConfig and Schema. The changes are straightforward and well-tested. For GenerationConfig, adding Equatable conformance is sufficient as the compiler can synthesize the implementation. For Schema, a manual implementation of Equatable is provided. I've suggested letting the compiler synthesize this as well for better maintainability. The new unit tests for Schema's Equatable conformance are comprehensive and cover various scenarios.

@andrewheard andrewheard marked this pull request as ready for review March 18, 2026 23:08
@andrewheard andrewheard requested a review from a team as a code owner March 18, 2026 23:08
@andrewheard andrewheard requested a review from paulb777 March 18, 2026 23:08
@andrewheard andrewheard merged commit d98b1e8 into main Mar 19, 2026
91 checks passed
@andrewheard andrewheard deleted the ah/ai-equatable-gen-config branch March 19, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants