[AI] Maps Grounding by paulb777 · Pull Request #15911 · firebase/firebase-ios-sdk

paulb777 · 2026-03-06T00:39:44Z

Inspired by firebase/firebase-js-sdk#9458

TODO: ADD text field and update integration test

gemini-code-assist · 2026-03-06T00:39:48Z

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

paulb777 · 2026-03-06T00:40:04Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces support for grounding with Google Maps, a valuable addition to the SDK's capabilities. The changes are well-structured, adding new data types for tool configuration and response handling, along with comprehensive unit and integration tests. My feedback includes a couple of minor suggestions: one to correct a documentation typo and another to add input validation for increased robustness. I've also proposed some refactoring in the new integration tests to enhance their clarity and conciseness.

FirebaseAI/Sources/Tool.swift

FirebaseAI/Tests/TestApp/Tests/Integration/MapsGroundingIntegrationTests.swift

FirebaseAI/Sources/GoogleMaps.swift

andrewheard · 2026-03-14T01:51:19Z

FirebaseAI/Sources/Types/Public/Tools/GoogleMaps.swift

nit: Should we put this file in Sources/Types/Public/Tools?

andrewheard · 2026-03-14T01:52:31Z

FirebaseAI/Sources/GoogleMaps.swift

+/// > Important: When using this feature, you are required to comply with the
+/// "Grounding with Google Maps" usage requirements for your chosen API provider.
+public struct GoogleMaps: Sendable, Encodable {
+  public init() {}


nit: Let's keep the initializer internal until we need to expose it.

andrewheard · 2026-03-14T01:53:20Z

FirebaseAI/Sources/Tool.swift

+  public static func googleMaps(_ googleMaps: GoogleMaps = GoogleMaps()) -> Tool {
+    return self.init(googleMaps: googleMaps)


Suggested change

public static func googleMaps(_ googleMaps: GoogleMaps = GoogleMaps()) -> Tool {

return self.init(googleMaps: googleMaps)

public static func googleMaps() -> Tool {

return self.init(googleMaps: GoogleMaps())

andrewheard · 2026-03-14T02:17:53Z

FirebaseAI/Sources/Tool.swift

+  public let latLng: LatLng
+
+  public init(latLng: LatLng) {
+    self.latLng = latLng
+  }
+
+  enum CodingKeys: String, CodingKey {
+    case latLng = "lat_lng"
+  }
+}
+
+/// An object that represents a latitude/longitude pair.
+public struct LatLng: Sendable, Encodable {
+  /// The latitude in degrees. It must be in the range [-90.0, +90.0].
+  public let latitude: Double
+  /// The longitude in degrees. It must be in the range [-180.0, +180.0].
+  public let longitude: Double
+
+  public init(latitude: Double, longitude: Double) {
+    precondition(
+      latitude >= -90.0 && latitude <= 90.0,
+      "Latitude must be in the range [-90.0, 90.0]."
+    )
+    precondition(
+      longitude >= -180.0 && longitude <= 180.0,
+      "Longitude must be in the range [-180.0, 180.0]."
+    )
+    self.latitude = latitude
+    self.longitude = longitude


Consider hiding the questionably named LatLng with an initializer that takes latitude and longitude:

Suggested change

public let latLng: LatLng

public init(latLng: LatLng) {

self.latLng = latLng

}

enum CodingKeys: String, CodingKey {

case latLng = "lat_lng"

}

}

/// An object that represents a latitude/longitude pair.

public struct LatLng: Sendable, Encodable {

/// The latitude in degrees. It must be in the range [-90.0, +90.0].

public let latitude: Double

/// The longitude in degrees. It must be in the range [-180.0, +180.0].

public let longitude: Double

public init(latitude: Double, longitude: Double) {

precondition(

latitude >= -90.0 && latitude <= 90.0,

"Latitude must be in the range [-90.0, 90.0]."

)

precondition(

longitude >= -180.0 && longitude <= 180.0,

"Longitude must be in the range [-180.0, 180.0]."

)

self.latitude = latitude

self.longitude = longitude

let latLng: LatLng

init(latLng: LatLng) {

self.latLng = latLng

}

public init(latitude: Double, longitude: Double) {

assert(

latitude >= -90.0 && latitude <= 90.0,

"Latitude must be in the range [-90.0, 90.0]."

)

assert(

longitude >= -180.0 && longitude <= 180.0,

"Longitude must be in the range [-180.0, 180.0]."

)

self.latLng = LatLng(latitude: latitude, longitude: longitude)

}

}

/// An object that represents a latitude/longitude pair.

struct LatLng: Sendable, Encodable {

/// The latitude in degrees. It must be in the range [-90.0, +90.0].

let latitude: Double

/// The longitude in degrees. It must be in the range [-180.0, +180.0].

let longitude: Double

init(latitude: Double, longitude: Double) {

or using the platform-native type CLLocationCoordinate2D:

Suggested change

public let latLng: LatLng

public init(latLng: LatLng) {

self.latLng = latLng

}

enum CodingKeys: String, CodingKey {

case latLng = "lat_lng"

}

}

/// An object that represents a latitude/longitude pair.

public struct LatLng: Sendable, Encodable {

/// The latitude in degrees. It must be in the range [-90.0, +90.0].

public let latitude: Double

/// The longitude in degrees. It must be in the range [-180.0, +180.0].

public let longitude: Double

public init(latitude: Double, longitude: Double) {

precondition(

latitude >= -90.0 && latitude <= 90.0,

"Latitude must be in the range [-90.0, 90.0]."

)

precondition(

longitude >= -180.0 && longitude <= 180.0,

"Longitude must be in the range [-180.0, 180.0]."

)

self.latitude = latitude

self.longitude = longitude

let latLng: LatLng

init(latLng: LatLng) {

self.latLng = latLng

}

public init(location: CLLocationCoordinate2D) {

assert(CLLocationCoordinate2DIsValid(location), """

Latitude must be in the range [-90.0, 90.0] and longitude must be in the range [-180.0, 180.0].

""")

self.latLng = LatLng(latitude: location.latitude, longitude: location.longitude)

}

}

/// An object that represents a latitude/longitude pair.

struct LatLng: Sendable, Encodable {

/// The latitude in degrees. It must be in the range [-90.0, +90.0].

let latitude: Double

/// The longitude in degrees. It must be in the range [-180.0, +180.0].

let longitude: Double

init(latitude: Double, longitude: Double) {

The latter would require import CoreLocation.

I thought we agreed with the group that LatLng should be public across platforms?

andrewheard · 2026-03-14T02:18:51Z

FirebaseAI/Sources/Tool.swift

+  enum CodingKeys: String, CodingKey {
+    case latLng = "lat_lng"
+  }


nit: This can be deleted.

andrewheard · 2026-03-14T02:19:29Z

FirebaseAI/Sources/Tool.swift

-extension ToolConfig: Encodable {}
+extension ToolConfig: Encodable {
+  enum CodingKeys: String, CodingKey {
+    case functionCallingConfig
+    case retrievalConfig = "retrieval_config"
+  }
+}


nit: This should be reverted.

andrewheard · 2026-03-14T02:23:34Z

FirebaseAI/Sources/Types/Public/Tools/GoogleMaps.swift

+}
+
+/// A grounding chunk sourced from Google Maps.
+public struct GoogleMapsGroundingChunk: Sendable, Equatable, Hashable, Decodable {


nit: Should this be nested inside GroundingMetadata to align with GroundingMetadata.WebGroundingChunk?

Not sure. It might be better to move WebGroundingChunk to its own file to align with Maps Grounding?

andrewheard · 2026-03-14T02:28:32Z

FirebaseAI/Sources/GoogleMaps.swift

+  public let uri: String
+  /// The title of the retrieved map data.
+  public let title: String
+  /// The Place ID of the retrieved map data.
+  public let placeID: String


Are these guaranteed to be non-nil?

Is there a recommended way to find out?

andrewheard · 2026-03-14T02:29:08Z

FirebaseAI/Sources/GoogleMaps.swift

+/// A grounding chunk sourced from Google Maps.
+public struct GoogleMapsGroundingChunk: Sendable, Equatable, Hashable, Decodable {
+  /// The URI of the retrieved map data.
+  public let uri: String


Would it be more idiomatic to provide a URL in Swift?

andrewheard · 2026-03-14T02:32:07Z

FirebaseAI/Sources/Types/Public/Tools/GoogleMaps.swift

+}
+
+/// A grounding chunk sourced from Google Maps.
+public struct GoogleMapsGroundingChunk: Sendable, Equatable, Hashable, Decodable {


Did we intentionally exclude text and placeAnswerSources?

https://ai.google.dev/api/generate-content#Maps

https://docs.cloud.google.com/vertex-ai/generative-ai/docs/reference/rest/v1beta1/GroundingMetadata#Maps

Vertex AI also has a route field.

Ongoing discussion in the API review. I haven't been able to get text included in a response.

danger-firebase-ios · 2026-03-14T23:23:58Z

	1 Warning
⚠️	New public headers were added, did you remember to add them to the umbrella header?

Generated by 🚫 Danger

paulb777 · 2026-03-18T21:27:34Z

FirebaseAI/Sources/Types/Public/Tools/GoogleMaps.swift

+  /// The URL of the retrieved map data.
+  public let url: URL?
+  /// The title of the retrieved map data.
+  public let title: String


Make these either nullable or defensively decode.

paulb777 marked this pull request as draft March 6, 2026 00:39

danger-firebase-ios bot added the api: firebaseai label Mar 6, 2026

gemini-code-assist bot reviewed Mar 6, 2026

View reviewed changes

paulb777 added 5 commits March 7, 2026 08:02

unit tests pass

a6305bc

Integration tests and style

ed5749a

retrievalConfig and LatLng

8ce4187

review

9fdcde5

style

67fa59f

paulb777 force-pushed the pb-maps-grounding branch from 6cd64a0 to 67fa59f Compare March 7, 2026 16:04

ryanwilson approved these changes Mar 9, 2026

View reviewed changes

FirebaseAI/Sources/GoogleMaps.swift Outdated Show resolved Hide resolved

paulb777 added 3 commits March 9, 2026 14:01

placeID not placeId

1916fa0

Merge remote-tracking branch 'origin/main' into pb-maps-grounding

af5f5a9

post-merge availability removals

a4b09f9

andrewheard reviewed Mar 14, 2026

View reviewed changes

review

fbe55e2

style

2a9280e

paulb777 commented Mar 18, 2026

View reviewed changes

		public static func googleMaps(_ googleMaps: GoogleMaps = GoogleMaps()) -> Tool {
		return self.init(googleMaps: googleMaps)

Conversation

paulb777 commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Mar 6, 2026

Uh oh!

paulb777 commented Mar 6, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danger-firebase-ios bot commented Mar 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

paulb777 commented Mar 6, 2026 •

edited

Loading