chore: move to latest depes, enable and apply dart_flutter_team_lints#204
chore: move to latest depes, enable and apply dart_flutter_team_lints#204
Conversation
Coverage Report✅ Coverage 74.56% meets 40% threshold Total Coverage: 74.56% Package Breakdown
Minimum threshold: 40% |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the project to use package:dart_flutter_team_lints, updates various dependency versions, and adopts workspace resolution for example packages. It also includes a significant cleanup of manual lint ignores and reorders exports alphabetically across several files. However, the changes introduce invalid Dart syntax in multiple locations by attempting to use a ? prefix for map values and list elements (e.g., 'key': ?value or [?element]) instead of the standard collection if syntax. These syntax errors must be corrected for the code to compile.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request migrates the project to package:dart_flutter_team_lints, updates various dependencies, and standardizes workspace configurations for example applications. While the migration successfully removes numerous manual lint ignores and standardizes the codebase, it introduces several critical syntax errors. Specifically, the use of invalid shorthand notation for conditional elements in map and list literals (such as ? and ...?) will result in compilation failures across multiple files.
- Move all dependencies to their latest version - Used `--tighten` command to bump min versions to bits that work on the supported SDK - Added `dart_flutter_team_lints` to workspace root `pubspec.yaml` - Centralized `analysis_options.yaml` in the workspace root - Replaced `all_lint_rules.yaml` with standard lint set - Removed redundant `analysis_options.yaml` from packages - Un-ignored previously ignored lints across the codebase - Applied fixes for newly enabled lints, including: - Replacing `null`-checks in lists with spread operator - Standardizing `ignore` comment usage - Removing duplicate/redundant imports - Updating dependency constraints - Fixing local variable shadowing - Removing private typedefs
2 participants
--tightencommand to bump min versions to bits that work on the supported SDKdart_flutter_team_lintsto workspace rootpubspec.yamlanalysis_options.yamlin the workspace rootall_lint_rules.yamlwith standard lint setanalysis_options.yamlfrom packagesnull-checks in lists with spread operatorignorecomment usage