Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR rewrites
audiowaveformin Rust and removes the legacy C++/CMake implementation from this repository.The repo is now centered on a Rust workspace with:
crates/audiowaveform: reusable library cratecrates/audiowaveform-cli: thin CLI wrapperIt also updates the repository metadata to reflect that this is the canonical FetLife-hosted Rust rewrite of the original BBC project.
Changes
Added a first-class Rust library for:
Symphonia.dat/.json/.txtserializationAdded a Rust CLI that keeps the familiar
audiowaveformcommand shape while using typed clap enums and styled help output.Expanded the Rust test suite to cover:
Consolidated fixtures into a single
fixtures/directory.Removed legacy project infrastructure:
Updated docs and metadata:
https://github.com/fetlife/audiowaveformNotes
Validation
cargo fmt --all cargo test --workspace cargo check --workspace --examples cargo check --workspace --quiet