Skip to content

Subdomain temperature fields#1060

Merged
jhdark merged 10 commits intofestim-dev:fenicsxfrom
jhdark:sub_temperature_fields
Feb 17, 2026
Merged

Subdomain temperature fields#1060
jhdark merged 10 commits intofestim-dev:fenicsxfrom
jhdark:sub_temperature_fields

Conversation

@jhdark
Copy link
Collaborator

@jhdark jhdark commented Jan 29, 2026

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 92.06349% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.82%. Comparing base (7958f49) to head (3cc8cbc).
⚠️ Report is 11 commits behind head on fenicsx.

Files with missing lines Patch % Lines
src/festim/hydrogen_transport_problem.py 91.22% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           fenicsx    #1060      +/-   ##
===========================================
- Coverage    94.90%   94.82%   -0.08%     
===========================================
  Files           44       44              
  Lines         3102     3132      +30     
===========================================
+ Hits          2944     2970      +26     
- Misses         158      162       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RemDelaporteMathurin
Copy link
Collaborator

I've fixed the documentation in #1065

@RemDelaporteMathurin RemDelaporteMathurin mentioned this pull request Feb 13, 2026
15 tasks
@jhdark jhdark merged commit 1ec8975 into festim-dev:fenicsx Feb 17, 2026
8 of 11 checks passed
@jhdark jhdark deleted the sub_temperature_fields branch February 17, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Can't couple heat transfer pb with mixed-domain H transport pb

2 participants

Comments