feat(ruby): add rubocopVariableNumberStyle config option#11428
Closed
iamnamananand996 wants to merge 4 commits intomainfrom
Closed
feat(ruby): add rubocopVariableNumberStyle config option#11428iamnamananand996 wants to merge 4 commits intomainfrom
iamnamananand996 wants to merge 4 commits intomainfrom
Conversation
The generated .rubocop.yml was using 'snake_case' style which requires underscores before numbers (e.g., 'recaptcha_v_2'). Changed to 'normalcase' style to allow field names like 'recaptcha_v2', 'office365', 'thumbprint_sha256', etc. without triggering lint errors. This matches the SDK's naming convention where lodash snakeCase produces names like 'recaptcha_v2' (not 'recaptcha_v_2'). Co-Authored-By: [email protected] <[email protected]>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Add configurable RuboCop Naming/VariableNumber style with three options: - snake_case (default): requires underscores before numbers (e.g., recaptcha_v_2) - normalcase: allows numbers without underscores (e.g., recaptcha_v2, office365) - disabled: disables the cop entirely This allows APIs with field names containing embedded digits to configure the appropriate style in their generators.yml. Co-Authored-By: [email protected] <[email protected]>
devin-ai-integration
bot
changed the title
Fix TypeScript TS1205 error: Re-exporting a type when 'isolatedModules' is enabled requires using 'export type'. Co-Authored-By: [email protected] <[email protected]>
Match existing pattern in other config schemas by inlining z.enum directly in the schema field instead of exporting separate schema constant and type. TypeScript infers the type from the schema. Co-Authored-By: [email protected] <[email protected]>
Contributor
|
This PR is stale because it has been open 25 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
github-actions
bot
added
the
Stale
Contributor
|
This PR was closed because it has been inactive for 5 days after being marked stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a configurable
rubocopVariableNumberStyleoption to control RuboCop'sNaming/VariableNumberstyle in generated Ruby SDKs. This allows APIs with field names containing embedded digits (e.g.,recaptcha_v2,office365,thumbprint_sha256) to configure the appropriate style.Link to Devin run: https://app.devin.ai/sessions/3d112cd502b04c18bc02bf2511fad7d2
Requested by: @iamnamananand996
Changes Made
rubocopVariableNumberStyleconfig option toBaseRubyCustomConfigSchemawith three values:snake_case(default): requires underscores before numbers (e.g.,recaptcha_v_2)normalcase: allows numbers without underscores (e.g.,recaptcha_v2,office365)disabled: disables the cop entirelyRubocopFile.tsto read from config and generate appropriate.rubocop.ymlcontentUsage
For APIs like auth0 with field names containing embedded digits, add to
generators.yml:Implementation Notes
z.enum()directly in the schema field, matching the existing pattern used by other config schemas (TypeScript, Python, Go, Java, PHP)Testing
pnpm run check)tsc --build)Human Review Checklist
snake_case,normalcase,disabled) generate correct.rubocop.ymloutputsnake_case) maintains backward compatibility for existing SDKsz.enum()pattern matches other config schemas in the codebase