fix(typescript): fix null check for nullable query parameters and passthrough serialization#11411
Closed
fix(typescript): fix null check for nullable query parameters and passthrough serialization#11411
Conversation
Co-Authored-By: judah@buildwithfern.com <jsklan.development@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: judah@buildwithfern.com <jsklan.development@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes two issues in the TypeScript SDK generator:
Date | null | undefined) are used in generated SDKsversion_numberandversionNumberappearing in parsed results)Link to Devin run: https://app.devin.ai/sessions/e8498bbef06245228a6e1502b58d2f36
Requested by: judah@buildwithfern.com (@jsklan)
Changes Made
Fix 1: Nullable Query Parameter Null Check
GeneratedQueryParams.withQueryParameter()to use!= nullinstead of!== undefinedfor nullable query parametersnullandundefinedvalues are properly handled before calling methods like.toISOString()on Date parametersBefore (generated code):
After (generated code):
Fix 2: Passthrough Serialization
passthrough()function in core-utilities to only preserve truly unknown keysTesting
Human Review Checklist
as Parsed & { [key: string]: unknown }) are safe and don't mask type errors