Added an option for a 'minimal view' in addition to the reduced view …#913
Added an option for a 'minimal view' in addition to the reduced view …#913njotto834 wants to merge 1 commit intofedericoiosue:developfrom
Conversation
…and extended view options.
|
Hi Nicholas, great job! Sorry for not having been completelly clear about any implementation's details into the issue #909 itself, I'll try to add more context here:
In this specific case the requirement was to implement that view as alternative to the currently "reduced" one, avoiding adding another entry into the menu, here the description:
This because the future version 7.x will get a complete refresh of the UI, with card view, and no more than 3 view options should be available through menu into the notes list. Another step further could be avoiding continue using "booleans and if/then" approach: if you want to try adding cleaner code you could try refactoring the whole thing in this sense (ex. creating an object that should represent the view mode and a factory to perform business logic on UI components depending on its state). All of this just because when I started the app I didn't plannet to see it grow like this, so starting since a day I tried keeping code much cleaner for future management, and pull requests really have to do the same to help to continue like this. |
cbb03b8 to
11c97fd
Compare
2edb3a1 to
5a0bb9f
Compare


…and extended view options.