Sync reminder with calendar button#848
Open
despgiat wants to merge 10 commits intofedericoiosue:developfrom
Open
Sync reminder with calendar button#848despgiat wants to merge 10 commits intofedericoiosue:developfrom
despgiat wants to merge 10 commits intofedericoiosue:developfrom
Conversation
… when clicked on, it creates the calendar event from the note.
Moved to exceptions, notified user in case of error
Owner
Really a great job, I've started using myself to test it and I'm finding it really useful!
Your version is actually really well integrated but could be broken by future (somewhere on the roadmap the interface will be deeply refactored) UI changes. By moving it into the menu would solve all of this!
By looking at the code nothing happens when a note or its reminder are deleted. So yes, performing something in these cases would completelly have sense |
federicoiosue
force-pushed
the
develop
branch
5 times, most recently
from
911df26 to
a6655ce
Compare
federicoiosue
force-pushed
the
develop
branch
2 times, most recently
from
cbb03b8 to
11c97fd
Compare
federicoiosue
force-pushed
the
develop
branch
from
2edb3a1 to
5a0bb9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I created a simple button to sync a note with the calendar below the "Add reminder" button in the fragment_detail_content.xml.
The "Sync reminder with Calendar" button appears only when there's a reminder in the Note and as of now it only creates a new event with the start and end time being the reminder's time through the Calendar Intent.
Is the button's placement okay below the reminder button or should I make the syncing an option in the options menu?
Also I could try to make a calendar helper script in order to be able to edit the existing events or delete them if the user decides to change or delete the reminder.