eventloop: add support for custom registrations#48188
Merged
Conversation
deg4uss3r
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to register a callback to be called when an
event::SetReadinessis invoked. TheEventLoop::register_custommethod is likeReactor::register_custom, except the backingevent::Registrationis managed internally and anevent::SetReadinessis returned.There is also some eventloop code rearrangement, using
mio::Interestinstead ofu8in the native API, and moving common bits into theeventmodule. In general, we want to keep native APIs idiomatic, even if they will only be used via FFIs, and we want FFIs to be organized similarly to the native APIs they wrap.