👷 Run mypy in pre-commit instead of Lint step in test.yml workflow#1511
Merged
👷 Run mypy in pre-commit instead of Lint step in test.yml workflow#1511
Lint step in test.yml workflow#1511Conversation
This reverts commit 7ca2faf.
YuriiMotov
changed the title
Lint step in test.yml workflowLint step in test.yml workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently linting is run by pre-commit (only ruff) and by
test.yml(lint.shscript for every python version except 3.9).This PR disables running linters in
test.ymland addsmypy checkhook to pre-commit.Checked that everything works by introducing typing issue: https://github.com/fastapi/typer/actions/runs/21621618931/job/62311751716?pr=1511#step:8:27