Convert Chapter 2 to use DDGo to smooth learning experience?#649
Open
sunlambda wants to merge 1 commit intofastai:masterfrom
Open
Convert Chapter 2 to use DDGo to smooth learning experience?#649sunlambda wants to merge 1 commit intofastai:masterfrom
sunlambda wants to merge 1 commit intofastai:masterfrom
Conversation
The actual text has not necessarily been updated, and saying that the images come from Bing isn't exactly inaccurate either.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Thanks for this! Unfortunately I get a RateLimitException trying to execute it. I am going to try again tomorrow with some delays between API calls to see if I can get it to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synopsis
Setting up a Microsoft Azure account for learning purposes is distracting, especially for Chapter 2. There has to be a keyless way to get some image URL's...I was just talking about this in #648 so I wanted to share my result.
Problem
I followed all the instructions (in Fastbook and elsewhere), but I was still having trouble creating the Azure cloud resource to do the Bing Image search (deployment failure, BadRequest, Internal Server Error).
Expected Behavior
Do Chapter 2 without signing up for more things, and to minimize the distractions so the attention can be paid to learning PyTorch.
Observed Behavior
I spent more time trying to figure out Azure portal, than simply adjusting the Chapter 2 to use
DDGSand submitting this PR! Now I can complete Chapter 2 and continue on with the book confidently.Proposed Solution
Use a
DDGSlibrary which requires no key, with the trade off of being limited by query volume.Content of this PR
Attached to this PR is a tested notebook which installs the referenced
DDGSlibrary. Then, any instances ofsearch_images_bingis replaced withddgs.images(**query_parameters), I was specific with the query parameters (small, public domain, etc.)TODO
The literature in the Notebook itself may need more updating, but the code should work and the notebook should run.