[Titanic] "Alone" feature should be true when there are no family members#20
Open
sandeeps- wants to merge 1 commit intofastai:masterfrom
Open
[Titanic] "Alone" feature should be true when there are no family members#20sandeeps- wants to merge 1 commit intofastai:masterfrom
sandeeps- wants to merge 1 commit intofastai:masterfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Shouldn't the code then be:
instead of
For the latter one, if the number of family members is say 2, then your code would return True, which is not what we want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Family members = number of siblings/spouses + number of parents/childen
Family members == 0 ==> Alone is true
Currently it is set as
df['Alone'] = df.Family==1My change makes it:
df['Alone'] = df.Family!=1