[Enhancement] Implementing dictification for ARRAY_AGG#2
Open
farhad-celo wants to merge 1 commit intomainfrom
Open
[Enhancement] Implementing dictification for ARRAY_AGG#2farhad-celo wants to merge 1 commit intomainfrom
farhad-celo wants to merge 1 commit intomainfrom
Conversation
7c6e28f to
d3f43a8
Compare
2c8eb77 to
503999d
Compare
Signed-off-by: Farhad Shahmohammadi <f.shahmohammadi@celonis.com>
503999d to
1fa8ac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
The Low Cardinality Optimization (LCO) currently does not support ARRAY_AGG. When ARRAY_AGG operates on low-cardinality string columns that have global dictionaries, the aggregation processes full VARCHAR values instead of compact integer-encoded dictionary IDs. This means ARRAY_AGG misses the performance benefits (reduced memory, faster comparisons) of dictification.
What I'm doing:
Extends the Low Cardinality Optimization to support ARRAY_AGG with dict-encoded columns. When the value column (first argument) of ARRAY_AGG has a global dictionary, the optimization:
Key changes:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: