⚡ Cache primer scoring tables in Repliconf#99
⚡ Cache primer scoring tables in Repliconf#99google-labs-jules[bot] wants to merge 1 commit intostablefrom
Conversation
Implemented caching for lookup table construction in Repliconf.search using @lru_cache. This optimizes cases where search is called repeatedly with the same primer and settings. Introduced _SettingsWrapper to allow caching based on settings object identity. Benchmarked improvement: ~26% reduction in execution time for setup-dominated workloads.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
47a5ea6 to
f204e89
Compare
Extracted the construction of
prim_score_lookupandstab_score_lookuptables into a standalone function_get_scoring_tablesdecorated with@lru_cache.To support
lru_cachewith unhashableReplicationSettingsobjects, a_SettingsWrapperclass was introduced which implements__hash__and__eq__based on object identity.This change reduces the overhead of
Repliconf.search()when called repeatedly with the same primer and settings, as the expensive table construction is performed only once and cached. Benchmarks showed a ~26% performance improvement in scenarios dominated by setup costs (short templates or frequent re-initialization).PR created automatically by Jules for task 879776912555508310 started by @fangfufu