Allow user to override the Limiter subclass check#27
Open
Cyberes wants to merge 1 commit intofalconry:masterfrom
Open
Allow user to override the Limiter subclass check#27Cyberes wants to merge 1 commit intofalconry:masterfrom
Cyberes wants to merge 1 commit intofalconry:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 67 67
Branches 10 10
=========================================
Hits 67 67
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the arg
ignore_subclasstoLimiterto enable the user to skip thestorage must be a subclass of StorageBasecheck.Here is my use-case:
As you can see, I am using multiprocessing's
BaseManagerto share theLimiterandMemoryStorageobjects withmultiprocessing.Process()processes. Withoutignore_subclass, the subclass check fails.