Skip to content

Conversation

@manishbalayan
Copy link

@manishbalayan manishbalayan commented Dec 4, 2025

Summary:

This PR related to issue #54789 updates the URL and URLSearchParams definitions in globals.d.ts to include missing standard properties and methods that are already supported by the runtime implementation.
Motivation:
I noticed that while the runtime supports standard URL operations (backed by whatwg-url), the TypeScript definitions were incomplete, causing unnecessary type errors when using standard Web APIs.

Changelog:

[GENERAL] [FIXED] - Added missing standard properties to URL (hash, host, pathname, etc.) and methods to URLSearchParams (get, set, delete, etc.).

Test Plan:

  1. Open globals.d.ts.
  2. Verify that URL interface now includes all standard properties.
  3. Verify that URLSearchParams interface now includes all standard methods.
  4. Verify that no new TypeScript errors are introduced.
    Screenshot:
    Before making changes
Screenshot 2025-12-04 at 11 38 58 PM After making changes ![Uploading Screenshot 2025-12-04 at 11.39.42 PM.png…]()

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2025
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 4, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 5, 2025

@alanleedev has imported this pull request. If you are a Meta employee, you can view this in D88517037.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants