remove selenium tests from circle.yml#509
Open
rwblair wants to merge 2 commits intoexpfactory:masterfrom
Open
Conversation
Member
|
I strongly advise to have a testing strategy in place before just deleting the old one. There are bugs that come from linting, but a large portion are issues with the experiment. This seems like a dangerous move to just delete it without having another plan :/ |
Member
|
hey @rwblair ! I was reviewing a JOSS submission and the author had a very similar experiment paradigm (not using JsPsych but with an experiment timeline akin to it) and he used a simple setup with npm test that I really liked - and it made me think of expfactory and that it might be something to improve upon the selenium here. In case it's useful, check out -> https://travis-ci.org/gasparl/citapp_pc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been a couple instances lately of experiments not being able to be merged due to experiments which couldn't be completed in testing or failed due to eccentricities of the circle environment. In the future we might update the information output by the test runner and dockerize the testing environment to allow for local replication of the issues.