Conversation
aleksanderkrauze
approved these changes
May 19, 2025
dergecko
approved these changes
May 28, 2025
Member
Author
|
Cc @davidristov just want to make sure you're ok with these changes before merging ? |
davidristov
approved these changes
Jun 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify kepler image
Simplified
keplerdockerfile and updated DOCS to usedocker execinstead of creating new container and than running commands in it withdocker run.I ran some tests using these
podmancommands to make sure importing was still working the same way as before.podman exec -it kepler kepler import_nist 2025 -d /dataREFS
I have
cargo fmt;cargo clippy;cargo testand all tests pass;