Merged
Conversation
a1cefbe to
9266415
Compare
9266415 to
837e49b
Compare
e03c901 to
9373615
Compare
dergecko
requested changes
May 16, 2025
Contributor
dergecko
left a comment
There was a problem hiding this comment.
praise
Really like the comments and structure of the code.
Also there a lot iof tests which makes it more maintainable in the future.
Member
Author
|
I think I covered all of your suggestions .
|
18f036d to
65bfeb6
Compare
bee05f8 to
648d1c1
Compare
648d1c1 to
1c9f9a0
Compare
dergecko
requested changes
May 19, 2025
Contributor
dergecko
left a comment
There was a problem hiding this comment.
Nice really like the comments.
Found some minor typos and one memroy related issue.
08f50ea to
79bf690
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve NIST data source importing
This primarily takes care of batch importing YEARLY CVE dataset imports from NIST .
Current BATCH_SIZE = 5000.
You can see a demo from importing and updating existing records in the ticket comments.
I have also touched on some minor details :
cvesandobjectstables. Stopping us from constantly having to ping the DB to check if CVE-ID and (cve-vendor-product) combination already exists.I'm not sure where the final place for the
BATCH_SIZEwill be (maybe it makes sense to move to ENV Variable)But for now i kept it in
kepler/domain-db/src/db/mod.rssince this is wherePostgresRepositoryis defined and where most of DB transactions are taking place.I have
cargo fmt;cargo clippy;cargo testand all tests pass;