internal/ethapi: add MaxUsedGas field to eth_simulateV1 response#32789
internal/ethapi: add MaxUsedGas field to eth_simulateV1 response#32789s1na merged 3 commits intoethereum:masterfrom
Conversation
|
@s1na I see @rjl493456442 assigned you to this, lmk if you'd like any changes or if I should just close, thanks |
|
There are 2 points about this PR:
|
ah, I didn't realize this required coordination with other clients, I can also implement in reth. will fix the implemntation issue, thanks |
|
@Rhovian so how it works is we need to update the spec here to add the field: https://github.com/ethereum/execution-apis/pulls And then ask clients e.g. in Eth r&d discord json rpc channel whether they are onboard with adding it. |
|
hey @s1na happy to make the PR and adjust this one as needed but i would hope to leave client consensus up to you as im not connected |
|
@Rhovian I can help with that |
Add optional `maxUsedGas` field to `SimCallResult`, mirroring ethereum/execution-apis#746 and ethereum/go-ethereum#32789. This field represents the maximum gas consumed during execution before refunds are applied, enabling more accurate gas limit estimation for complex transaction sequences. Amp-Thread-ID: https://ampcode.com/threads/T-019c6b14-bfd0-71df-bce9-533057940778 Co-authored-by: Amp <[email protected]>
|
@s1na looks like this is moving along with prs in alloy & reth, lmk if I can be of assitance |
s1na
left a comment
There was a problem hiding this comment.
LGTM thanks for pushing it through the process
closes #32741