fix(staking): remove excessive whitespace in SaaS product cards#18081
Open
konopkja wants to merge 3 commits intoethereum:devfrom
Open
fix(staking): remove excessive whitespace in SaaS product cards#18081konopkja wants to merge 3 commits intoethereum:devfrom
konopkja wants to merge 3 commits intoethereum:devfrom
Conversation
The tags wrapper used `min-h-75` (300px in Tailwind v4), which reserved ~200px of empty space below the tags on cards with 1-3 tag rows. Cards already align via the parent CSS Grid's implicit `align-items: stretch`, so the fixed minimum is unnecessary. Closes ethereum#18080
konopkja
requested review from
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #18080.
The product cards on
/staking/saas/(and the parallel pools/solo pages, since they shareStakingProductCard) render with a large band of empty space between the platform/UI tags and the considerations list.Root cause
src/components/Staking/StakingProductsCardGrid/StakingProductCard.tsx:181set the tags wrapper tomin-h-75. In Tailwind v4 (this repo on[email protected])min-h-75resolves tomin-height: calc(0.25rem * 75) = 18.75rem ≈ 300px. Cards rarely have more than 1–3 lines of tags (~30–80px), so 200+px of unused vertical space appears on most cards.The minimum was introduced in commit
80ba1452c9(Oct 2024) presumably to align the considerations-list start position across cards in the same row.Why removing it is safe
StakingProductsCardGrid/index.tsx:17) isgrid grid-cols-fill-4 gap-6. CSS Grid already stretches sibling cards to equal heights via implicitalign-items: stretch.flex flex-colwithmt-autoon the footer, so the "Get started" button stays pinned to the bottom regardless of internal content height.Tradeoff
With the fixed min-height removed, the considerations list can start at slightly different y-positions across cards in the same row when tag counts differ. Total card heights remain aligned (grid stretch). If horizontal alignment of the considerations section is a hard requirement, the alternative is to shrink
min-h-75to a realistic value (e.g.min-h-20≈ 80px) instead of removing it. Happy to swap if reviewers prefer.Type of change
Affected pages
/staking/saas//staking/pools//staking/solo/(All three render
StakingProductCard.)Testing
pnpm lintpasses for the touched file./staking/saas/.Screenshots
The bug is shown in #18080 (excessive whitespace below tag row). I don't have a deployed preview yet — Vercel preview will show the fix.