Skip to content

Implement data layer across pages #16839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
corwintines wants to merge 4 commits into from
Closed

Implement data layer across pages #16839

corwintines wants to merge 4 commits into from

Conversation

@corwintines
Copy link
Member

@corwintines corwintines commented Dec 10, 2025 •
edited
Loading

Description

  • Removes old implementation of dataLoader
  • Removes old mocks implementation
  • Implements data loader across all React pages on ethereum.org

Depends on #16801 and #16830

@netlify
Copy link

netlify bot commented Dec 10, 2025 •
edited
Loading

❌ Deploy Preview for ethereumorg failed.

Name Link
🔨 Latest commit 3a1acfb
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/6938f36d8397ab0008a741f7

@github-actions github-actions bot added dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project labels Dec 10, 2025
@corwintines corwintines changed the base branch from dev to datalayer-layer2Page December 10, 2025 04:14
@corwintines corwintines marked this pull request as draft December 10, 2025 04:15
@corwintines
Copy link
Member Author

corwintines commented Dec 11, 2025

Refactored the data layer, so going to close this out for that implementation

@github-actions github-actions bot added the abandoned This has been abandoned or will not be implemented label Dec 11, 2025
@corwintines corwintines deleted the datalayer-pages branch December 11, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wackerow wackerow Awaiting requested review from wackerow

@pettinarip pettinarip Awaiting requested review from pettinarip

@minimalsm minimalsm Awaiting requested review from minimalsm

Assignees

No one assigned

Labels

abandoned This has been abandoned or will not be implemented dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@corwintines