Skip to content

Add character counters to form fields #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pettinarip wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add character counters to form fields #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10960fa
add char counter to fields
pettinarip Jun 2, 2025
7212083
update forms to use char counter
pettinarip Jun 2, 2025
eb1207e
more migration
pettinarip Jun 15, 2025
100f130
fixes
pettinarip Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/forms/AcademicGrantsForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,13 @@ export const AcademicGrantsForm: FC = () => {
<TextField
id='firstName'
label='First name'
maxLength={40}
isRequired
mr={{ md: 12 }}
mb={{ base: 8, md: 0 }}
/>

<TextField id='lastName' label='Last name' isRequired />
<TextField id='lastName' label='Last name' maxLength={80} isRequired />
</Flex>

{!errors?.firstName && !errors?.lastName && (
Expand Down Expand Up @@ -400,7 +401,7 @@ export const AcademicGrantsForm: FC = () => {
)}
/>

<TextField id='requestAmount' label='Amount' isRequired />
<TextField id='requestAmount' label='Amount' hideCharCounter isRequired />
</Flex>
</Stack>

Expand Down Expand Up @@ -487,6 +488,7 @@ export const AcademicGrantsForm: FC = () => {
id='alternativeContact'
label='Telegram username or alternative contact info'
helpText="In regards to your submission, we'll get in touch with you via email by default. As backup, if you'd like to provide alternative contact info, you may do so"
maxLength={150}
/>

<Controller
Expand Down
7 changes: 4 additions & 3 deletions src/components/forms/DestinoDevconnectForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ export const DestinoDevconnectForm: FC = () => {
<PageSection>Contact Information</PageSection>

<Flex direction={{ base: 'column', md: 'row' }} gap={8}>
<TextField id='firstName' label='First Name' isRequired />
<TextField id='lastName' label='Last Name' isRequired />
<TextField id='firstName' label='First Name' maxLength={40} isRequired />
<TextField id='lastName' label='Last Name' maxLength={80} isRequired />
</Flex>

<TextField id='email' label='Email' isRequired />
Expand Down Expand Up @@ -137,6 +137,7 @@ export const DestinoDevconnectForm: FC = () => {
<TextField
id='alternativeContact'
label='Telegram Username or Alternative Contact Info'
maxLength={150}
/>

<Flex direction={{ base: 'column', md: 'row' }} gap={8}>
Expand Down Expand Up @@ -376,7 +377,7 @@ export const DestinoDevconnectForm: FC = () => {
)}
/>

<TextField id='requestedAmount' label='Amount' isRequired />
<TextField id='requestedAmount' label='Amount' hideCharCounter isRequired />
</Flex>
</>
)}
Expand Down
6 changes: 4 additions & 2 deletions src/components/forms/EPFApplicationForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,13 @@ export const EPFApplicationForm: FC = () => {
<TextField
id='firstName'
label='First name'
maxLength={40}
isRequired
mr={{ md: 12 }}
mb={{ base: 8, md: 0 }}
/>

<TextField id='lastName' label='Last name' isRequired />
<TextField id='lastName' label='Last name' maxLength={80} isRequired />
</Flex>

{!errors?.firstName && !errors?.lastName && (
Expand Down Expand Up @@ -247,7 +248,7 @@ export const EPFApplicationForm: FC = () => {
)}
/>

<TextField id='requestedAmount' label='Budget request' isRequired />
<TextField id='requestedAmount' label='Budget request' hideCharCounter isRequired />

<TextAreaField
id='proposedTimeline'
Expand Down Expand Up @@ -286,6 +287,7 @@ export const EPFApplicationForm: FC = () => {
id='alternativeContact'
label='Telegram username or alternative contact info'
helpText="In regards to your submission, we'll get in touch with you via email by default. As backup, if you'd like to provide alternative contact info, you may do so. Not required"
maxLength={150}
/>

<Controller
Expand Down
Loading