Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

test(contracts): enhance LegacyMintableERC20 test coverage

Summary

Enhances the LegacyMintableERC20 test file with improved coverage and quality:

  • Fuzz test conversions: Converted 4 focused tests to fuzz tests (mint/burn success and revert cases) to test with randomized addresses and amounts
  • Event verification: Added vm.expectEmit checks for Mint and Burn events
  • New coverage: Added fuzz test for supportsInterface returning false for unsupported interface IDs
  • Naming conventions: Fixed test function names (workssucceeds) and added descriptive scenario names

Review & Testing Checklist for Human

  • Verify event emission tests work correctly - the test file declares events with camelCase parameters while source uses underscore-prefixed parameters (should match by signature, not names)
  • Confirm fuzz test constraints are appropriate: vm.assume(_to != address(0)) for mint, vm.assume(_caller != address(l2StandardBridge)) for non-bridge tests

Test plan: Run just test-dev --match-path test/legacy/LegacyMintableERC20.t.sol -v to verify all 7 tests pass.

Notes

Link to Devin run: https://app.devin.ai/sessions/079e16162e3845be98a3418bff98a28f
Requested by: Ariel Diaz (@aliersh)

Last update: 2026-02-02 02:15 ET

- Convert mint/burn tests to fuzz tests for broader coverage
- Add event emission verification for Mint and Burn events
- Add fuzz test for unsupported interface IDs
- Fix test naming conventions (works -> succeeds)
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner February 2, 2026 07:15
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.6%. Comparing base (a0a2a92) to head (22f3c79).

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #19041     +/-   ##
==========================================
+ Coverage     76.3%    81.6%   +5.2%     
==========================================
  Files          188      133     -55     
  Lines        10937     6907   -4030     
==========================================
- Hits          8353     5641   -2712     
+ Misses        2438     1266   -1172     
+ Partials       146        0    -146     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 81.6% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 56 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@alcueca alcueca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant